diff --git a/changelog.d/17817.bugfix b/changelog.d/17817.bugfix new file mode 100644 index 00000000000..5dd276709b0 --- /dev/null +++ b/changelog.d/17817.bugfix @@ -0,0 +1 @@ +Avoid lost data on some database query retries. diff --git a/synapse/storage/databases/main/search.py b/synapse/storage/databases/main/search.py index b436275f3fd..1d5c5e72ffc 100644 --- a/synapse/storage/databases/main/search.py +++ b/synapse/storage/databases/main/search.py @@ -94,7 +94,7 @@ def store_search_entries_txn( VALUES (?,?,?,to_tsvector('english', ?),?,?) """ - args1 = ( + args1 = [ ( entry.event_id, entry.room_id, @@ -104,7 +104,7 @@ def store_search_entries_txn( entry.origin_server_ts, ) for entry in entries - ) + ] txn.execute_batch(sql, args1)