room creation fails if sydent cannot send emails.

[pluex1]

Description

If a user wants to invite someone by e-mail and sydent cannot send this e-mail because e.g. smtp authentication fails, the room creation in synapse fails and only an empty room is displayed in element.

Steps to reproduce

have setup synapse, element, sydent
Make sydent the Identity Server.
Configure e.g. wrong credentials ore wrong tlsmode in sydent.

Homeserver

another homeserver

Synapse Version

1.96.1

Installation Method

Docker (matrixdotorg/synapse)

Database

single PostgreSQL, no, no

Workers

Single process

Platform

in k8s

Configuration

no

Relevant log output

- synapse.http.server - 140 - ERROR - POST-77832 - Failed handle request via 'RoomCreateRestServlet': <XForwardedForRequest at 0x7f030c977c10 method='POST' uri='/_matrix/client/v3/createRoom' clientproto='HTTP/1.1' site='8008'>
Traceback (most recent call last):
  File "/usr/local/lib/python3.11/site-packages/synapse/http/server.py", line 326, in _async_render_wrapper
    callback_return = await self._async_render(request)
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/synapse/http/server.py", line 538, in _async_render
    callback_return = await raw_callback_return
                      ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/synapse/rest/client/room.py", line 165, in on_POST
    return await self._do(request, requester)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/synapse/rest/client/room.py", line 170, in _do
    room_id, _, _ = await self._room_creation_handler.create_room(
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/synapse/handlers/room.py", line 982, in create_room
    ) = await self.hs.get_room_member_handler().do_3pid_invite(
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/synapse/handlers/room_member.py", line 1591, in do_3pid_invite
    event, stream_id = await self._make_and_store_3pid_invite(
                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/synapse/handlers/room_member.py", line 1675, in _make_and_store_3pid_invite
    ) = await self.identity_handler.ask_id_server_for_third_party_invite(
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/synapse/handlers/identity.py", line 751, in ask_id_server_for_third_party_invite
    data = await self._http_client.post_json_get_json(
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/synapse/http/client.py", line 527, in post_json_get_json
    raise HttpResponseException(
synapse.api.errors.HttpResponseException: 500: Internal Server Error

Anything else that would be useful to know?

No response