Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always use RETURNING once the minimum supported SQLite version is 3.35.0 #17577

Open
AndrewFerr opened this issue Aug 15, 2024 · 0 comments
Open

Comments

@AndrewFerr
Copy link
Member

The minimum supported version of SQLite3 at the time of writing is 3.34 (since that's what's in Debian oldstable right now), which doesn't support the RETURNING clause in INSERT/UPDATE/DELETE queries. That means every such usage of RETURNING must be gated by a check to BaseDatabaseEngine.supports_returning or when it's known that a Postgres database is in use.

The earliest version of SQLite3 to support this usage of RETURNING is 3.35.0, so once the minimum supported version is that or newer, Synapse can assume RETURNING is always available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants