Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New faces #31

Open
fniessen opened this issue Sep 26, 2014 · 5 comments
Open

New faces #31

fniessen opened this issue Sep 26, 2014 · 5 comments

Comments

@fniessen
Copy link

Thanks for this revolutionizing way to search for expressions throughout our buffers...

Here a feature request: could we have an extra face

  • for line numbers in the Swoop window?
  • for target words not in the highlighted line?

See http://screencast.com/t/YV71bHU6ui for an illustration.

Thanks.

@ShingoFukuyama
Copy link
Contributor

Thank you for the request with the lucid illustration.

It's a nice to slightly discriminate faces between on and off the target-line.
As to the face of line numbers, it could slow down the performance but it's also nice to add it as an option.
I will add those changes on the next update.

Thanks.

@fniessen
Copy link
Author

Thanks!

@palikar
Copy link
Contributor

palikar commented May 13, 2020

Is this feature still considered? Are you interested in PRs for this and in general for the issues marked with "feature request"?

@cireu
Copy link
Collaborator

cireu commented May 13, 2020

Is this feature still considered? Are you interested in PRs for this and in general for the issues marked with "feature request"?

Any PR welcome ;)

@palikar
Copy link
Contributor

palikar commented May 14, 2020

This issue seems to be already solved. There are custom variables for the suggested faces

(defcustom helm-swoop-use-line-number-face nil ... ) 
...
(defcustom helm-swoop-line-number-face ... )
(defcustom helm-swoop-target-word-face ...)
(defcustom helm-swoop-target-line-face ...)

To note is that for those to be used, one must set the custom variable helm-swoop-speed-or-color to non-nil.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants