Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Snapshot tests fail withunity feature #5297

Closed
lucasmerlin opened this issue Oct 22, 2024 · 0 comments · Fixed by #5542
Closed

Snapshot tests fail withunity feature #5297

lucasmerlin opened this issue Oct 22, 2024 · 0 comments · Fixed by #5542
Assignees
@lucasmerlin
Labels
bug Something is broken CI Continues Integration test tests Unit tests, regression tests, manual tests, …

Comments

@lucasmerlin
Copy link
Collaborator

lucasmerlin commented Oct 22, 2024 •
edited
Loading

Describe the bug
Running the tests with cargo test --workspace --all-features currently fails because the unity feature isn't compatible with egui_wgpu. This means we currently aren't running tests with all possible features.

Expected behavior
Should be possible to run tests with --all-features

This was broken in #5166 (intentionally, in order to not make that PR even bigger)
@lucasmerlin lucasmerlin added bug Something is broken CI Continues Integration test tests Unit tests, regression tests, manual tests, … labels Oct 22, 2024
@lucasmerlin lucasmerlin mentioned this issue Oct 22, 2024
Merged
1 task
lucasmerlin added a commit that referenced this issue Oct 24, 2024
@lucasmerlin @emilk
Fix cargo test in check.sh (#5299)
5b846b4 
The check.sh script was broken in #5166, this fixes it
* Related to #5297 
* [x] I have followed the instructions in the PR template

---------

Co-authored-by: Emil Ernerfeldt <[email protected]>
lucasmerlin added a commit that referenced this issue Oct 27, 2024
@lucasmerlin @emilk
Fix cargo test in check.sh (#5299)
5072ee5 
The check.sh script was broken in #5166, this fixes it
* Related to #5297 
* [x] I have followed the instructions in the PR template

---------

Co-authored-by: Emil Ernerfeldt <[email protected]>
lucasmerlin added a commit that referenced this issue Oct 29, 2024
@lucasmerlin @emilk
Fix cargo test in check.sh (#5299)
c93846c 
The check.sh script was broken in #5166, this fixes it
* Related to #5297 
* [x] I have followed the instructions in the PR template

---------

Co-authored-by: Emil Ernerfeldt <[email protected]>
hacknus pushed a commit to hacknus/egui that referenced this issue Oct 30, 2024
@lucasmerlin @emilk @hacknus
Fix cargo test in check.sh (emilk#5299)
a1f5b09 
The check.sh script was broken in emilk#5166, this fixes it
* Related to emilk#5297 
* [x] I have followed the instructions in the PR template

---------

Co-authored-by: Emil Ernerfeldt <[email protected]>
@lucasmerlin lucasmerlin mentioned this issue Dec 29, 2024
Merged
1 task
@lucasmerlin lucasmerlin self-assigned this Dec 29, 2024
lucasmerlin added a commit that referenced this issue Dec 30, 2024
@lucasmerlin
Fix cargo test --all-features breaking rendering due to unity vertexes (
86ea3f8 
#5542)

* Closes #5297 
* [x] I have followed the instructions in the PR template

It's not great but I wasn't able to come up with a better solution.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lucasmerlin lucasmerlin

Labels
bug Something is broken CI Continues Integration test tests Unit tests, regression tests, manual tests, …
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix cargo test --all-features breaking rendering due to unity vertexes emilk/egui
1 participant
@lucasmerlin