Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate poetry to uv #350

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

pavel-anchev
Copy link

No description provided.

@pavel-anchev pavel-anchev marked this pull request as ready for review December 9, 2024 19:12
@pavel-anchev pavel-anchev changed the title Draft: Migrate poetry to uv Migrate poetry to uv Dec 9, 2024
@empicano
Copy link
Owner

empicano commented Jan 9, 2025

I'm terribly sorry for the long wait, lots to do at work and then Christmas. This is a very good start, thank you! 😎

I've added a commit with some small tweaks: Inside pyproject.toml, the ruff version was translated from ^0.4.8 to >=0.4.8,<1.0.0, but the exact translation is >=0.4.8,<0.5.0 (same for sphinx-copybutton). This incidentally updated ruff "too far" and which raised some new lint errors. In fact, it's a good idea to update the ruff version (and fix these new lint errors), but let's do that in a different PR 🙂

Also (slightly nitpicky): Inside CONTRIBUTING.md we don't need to run uv python install and uv venv. uv sync does that automatically for us. I find that really cool that uv manages the Python version automatically!


As far as I can see, this is what's left to do:

  1. Automate the version incrementation somehow. With poetry we used poetry-dynamic-versioning to automatically declare aiomqtt's version based on the GitHub release when we publish a new version. That's why the version is declared as 0.0.0 in the pyproject.toml 🙂 Having something similar would be great to avoid duplication and user error
  2. Get the test and documentation workflows running
  3. Test publishing aiomqtt with workflow to Test PyPI

You've asked for help (which is great!) in the issue. I know that I've tagged the issue as "good first issue" and these remaining points are not trivial. Do you want to try to tackle them with some pointers from me, or do you want to leave them to me? Both is ok!

@empicano empicano linked an issue Jan 9, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move from poetry+pyenv to uv
3 participants