Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimisation: Replacing listView in CarSelectionActivity with Recycler View having well designed Cardviews #674

Open
swayamkaul opened this issue Mar 26, 2021 · 12 comments

Comments

@swayamkaul
Copy link

Screenshot 2021-03-27 at 2 26 30 AM
This activity presently contains listView for showing the list of cars which is not an efficient approach.
This listView needs to be replaced with RecyclerView having well designed CardViews which will lead to a better UserInterface as well as better app performance.

@cdhiraj40
Copy link
Contributor

its been more than 4 months if @swayamkaul you have not done yet can i work on it? @asaikarthikeya

@asaikarthikeya
Copy link
Member

@DhirajChauhan40 Yes, you can work on this. Could you provide a mock up design on how you would like to improve the design ?

@cdhiraj40
Copy link
Contributor

cdhiraj40 commented Aug 23, 2021

yes @asaikarthikeya I have a design which i used in my hotel app project, its pretty subtle and at the same time looks good I can show you the screenshots

@asaikarthikeya
Copy link
Member

yes @asaikarthikeya I have a design which i used in my hotel app project, its pretty subtle and at the same time looks good I can show you the screenshots

You can use that design and add the items and views of this layout. You can share the mock up after adapting the change

@cdhiraj40
Copy link
Contributor

@asaikarthikeya I'm having difficulty with connecting all the files and data which is from other different java files, can you help me?

@asaikarthikeya
Copy link
Member

@DhirajChauhan40 Sure. Actually, This issue is not a beginner friendly one, and the design aspect involved in this issue needs some internal discussion before finalizing and working on. I would suggest you to work on a few relatively easy issue which make you familiar with the code base of enviroCar. Then you can take on the challenging onces. Feel free to ask doubts. I will try to answer them in my free time :)

@cdhiraj40
Copy link
Contributor

cdhiraj40 commented Aug 25, 2021

@DhirajChauhan40 Sure. Actually, This issue is not a beginner friendly one, and the design aspect involved in this issue needs some internal discussion before finalizing and working on. I would suggest you to work on a few relatively easy issue which make you familiar with the code base of enviroCar. Then you can take on the challenging onces. Feel free to ask doubts. I will try to answer them in my free time :)

oh sure actually today i had talk with Benjamin(mentor) and he also said the same to me
so do you have some issues in your mind which you can state here
will be really helpful! @asaikarthikeya

@asaikarthikeya
Copy link
Member

@DhirajChauhan40 I will find create/ find a issue and tag you there.

@cdhiraj40
Copy link
Contributor

@DhirajChauhan40 I will find create/ find a issue and tag you there.

thank you so much!!

@MohitGupta121
Copy link

Is this issue is still open, I want to work on this issue @cdhiraj40 ?

@asaikarthikeya
Copy link
Member

Is this issue is still open, I want to work on this issue @cdhiraj40 ?

Yes, It is open. please refer to the above conversation. Thanks

@MohitGupta121
Copy link

Okay thanks you. I'll check some other issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants