-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimisation: Replacing listView in CarSelectionActivity with Recycler View having well designed Cardviews #674
Comments
its been more than 4 months if @swayamkaul you have not done yet can i work on it? @asaikarthikeya |
@DhirajChauhan40 Yes, you can work on this. Could you provide a mock up design on how you would like to improve the design ? |
yes @asaikarthikeya I have a design which i used in my hotel app project, its pretty subtle and at the same time looks good I can show you the screenshots |
You can use that design and add the items and views of this layout. You can share the mock up after adapting the change |
@asaikarthikeya I'm having difficulty with connecting all the files and data which is from other different java files, can you help me? |
@DhirajChauhan40 Sure. Actually, This issue is not a beginner friendly one, and the design aspect involved in this issue needs some internal discussion before finalizing and working on. I would suggest you to work on a few relatively easy issue which make you familiar with the code base of enviroCar. Then you can take on the challenging onces. Feel free to ask doubts. I will try to answer them in my free time :) |
oh sure actually today i had talk with Benjamin(mentor) and he also said the same to me |
@DhirajChauhan40 I will find create/ find a issue and tag you there. |
thank you so much!! |
Is this issue is still open, I want to work on this issue @cdhiraj40 ? |
Yes, It is open. please refer to the above conversation. Thanks |
Okay thanks you. I'll check some other issues. |
This activity presently contains listView for showing the list of cars which is not an efficient approach.
This listView needs to be replaced with RecyclerView having well designed CardViews which will lead to a better UserInterface as well as better app performance.
The text was updated successfully, but these errors were encountered: