AuthTokenManager.get_or_create calls wrong create

[hodunov]

Hi!
Thanks for the library, it really helped me solve my problem. But while implementing authorization via GraphQL I encountered the following problem: AuthToken.objects.get_or_create(user=user, client=auth_client) method does not work correctly.
Expected behavior: classic get_or_create
Real result: error NOT NULL constraint failed: durin_authtoken.expiry

A piece of code in which an error occurs:

login(request, user)
token, created = AuthToken.objects.get_or_create(user=user, client=auth_client)

If I wrap it in try-exept, everything works as it should.

try:
    token = AuthToken.objects.get(user=user, client=auth_client)
except AuthToken.DoesNotExist:
    token = AuthToken.objects.create(user=user, client=auth_client)

[eshaan7]

Hi, @hodunov. It makes me glad that you found this library useful.

So I can better address this issue, can you let me know the python and django versions your project is using ?

[eshaan7]

If you see the code inside durin/models.py, we have a custom AuthTokenManager where the create method is overwritten. It seems as though that the get_or_create in your example is calling the default create and not the overwritten create of AuthTokenManager.

On digging more into this, I find that this was fixed in Django v1.8a1 as mentioned in this StackOverflow thread, quoted below,

Just want to clarify that this issue was addressed in Django v1.8a1. So now both get_or_create and update_or_create will call the managers create method as expected.

[hodunov]

Hi, @hodunov. It makes me glad that you found this library useful.
So I can better address this issue, can you let me know the python and django versions your project is using ?

Yes, of course, no problem. Django==3.2 with python 3.8

Absolutely right, rushed and did not describe my thoughts on this matter. I agree that the reason is exactly in models.Manager.
And yes, I saw that get_or_create method should work with manager, but it doesn't, check it yourself.

[sunweiyang]

I have an interesting situation too -- AuthToken.objects.get_or_create works in most cases, but when I'm performing Django unit tests, AuthToken.objects.get_or_create within the API views I'm testing doesn't work (but they do work in the unit tests themselves, before I call the API views!).