Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rule Change[no-missing-label-refs]: support GFM alerts #310

Closed
1 task done
DMartens opened this issue Jan 2, 2025 · 0 comments
Closed
1 task done

Rule Change[no-missing-label-refs]: support GFM alerts #310

DMartens opened this issue Jan 2, 2025 · 0 comments

Comments

@DMartens
Copy link
Contributor

DMartens commented Jan 2, 2025

What rule do you want to change?

no-missing-label-refs

What change do you want to make?

Generate fewer warnings

How do you think the change should be implemented?

A new default behavior

Example code

> [!NOTE]
> Description

What does the rule currently do for this code?

The rule uses a regular expression to find missing labels but does not ignore GFM-style alerts.

What will the rule do after it's changed?

Ignore the alerts (e.g. [!NOTE]) as they are not a link reference.

Participation

  • I am willing to submit a pull request to implement this change.

Additional comments

It seems that rules have no access to which language is used and as such the change would also affect the commonmark mode.

@eslintbot eslintbot added this to Triage Jan 2, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Jan 2, 2025
@nzakas nzakas closed this as completed Jan 2, 2025
@github-project-automation github-project-automation bot moved this from Needs Triage to Complete in Triage Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Complete
Development

No branches or pull requests

2 participants