Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using sdkconfig editor on sdkconfig.defaults fills it with redundant settings. (IEP-1399) #1117

Open
emaayan opened this issue Jan 14, 2025 · 2 comments
Assignees

Comments

@emaayan
Copy link

emaayan commented Jan 14, 2025

Describe the bug
when double clicking on sdkconfig.defaults it launches the configuration editor, which automatically fills with with every default configuration there is.

To Reproduce
Steps to reproduce the behavior:

  1. double sdkconfig.defaults, and wait for the editor to open
  2. RCM on sdkconfig.defaults and open with text editor
  3. the file is full of settings

Expected behavior
the file should only contain the actual settings that were changed.

Screenshots
If applicable, add screenshots to help explain your problem.

Espressif-IDE Product Information:
Espressif > Product Information (Copy content from the console and attach as a file)

the whole point of sdkconfig.defaults is to have the minimal change settings required for the project rather than getting lost between myriad of other options that obscure what you really want to configure, it doesn't even wait for the editor to save, to give you a chance to revert the file, it just litters it with defaults.

@github-actions github-actions bot changed the title using sdkconfig editor on sdkconfig.defaults fills it with redundant settings. using sdkconfig editor on sdkconfig.defaults fills it with redundant settings. (IEP-1399) Jan 14, 2025
@sigmaaa sigmaaa self-assigned this Jan 15, 2025
@sigmaaa
Copy link
Collaborator

sigmaaa commented Jan 15, 2025

Hi @emaayan,

You’re right about the purpose of the sdkconfig.defaults. We should probably change the pattern to exclude sdkconfig.defaults files from being opened with the SDKConfig editor. Since these files contain only a few settings, there’s little benefit in using the SDKConfig editor for them.

As a workaround for now, you can do the following:

  1. Right-click on the sdkconfig.defaults file.
  2. Select Open with -> Other....
  3. Choose Generic Text Editor for all sdkconfig.defaults files.
    image

@emaayan
Copy link
Author

emaayan commented Jan 15, 2025

Hi @emaayan,

You’re right about the purpose of the sdkconfig.defaults. We should probably change the pattern to exclude sdkconfig.defaults files from being opened with the SDKConfig editor. Since these files contain only a few settings, there’s little benefit in using the SDKConfig editor for them.

As a workaround for now, you can do the following:

  1. Right-click on the sdkconfig.defaults file.
  2. Select Open with -> Other....
  3. Choose Generic Text Editor for all sdkconfig.defaults files.
    image

thanks, not ust pure defaults, but also defaults.s3 etc.. but you should give it some minimal color syntax highlighting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants