Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Espressif IDE created an invalid .clang-format file (IEP-1404) #1121

Open
emaayan opened this issue Jan 20, 2025 · 2 comments
Open

Espressif IDE created an invalid .clang-format file (IEP-1404) #1121

emaayan opened this issue Jan 20, 2025 · 2 comments
Assignees

Comments

@emaayan
Copy link

emaayan commented Jan 20, 2025

Describe the bug
espressif ide new idf project wizards creates an invalid .clang-format file

To Reproduce
Steps to reproduce the behavior:

  1. Go to file ->new
  2. Click on new esp idf project
  3. create the minimal project

.clang-format file will contain the parameter PackConstructorInitializers: NextLineOnly if you attempt to use file with clang-format manually you will see an error on this parameter.


# We'll use defaults from the LLVM style, but with some modifications so that it's close to the CDT K&R style.
BasedOnStyle: LLVM
UseTab: Always
IndentWidth: 4
TabWidth: 10
PackConstructorInitializers: NextLineOnly
BreakConstructorInitializers: AfterColon
IndentAccessModifiers: false
AccessModifierOffset: -4
ColumnLimit: 200

Expected behavior
clang-formatting rules being applied after using format source on eclipse

Screenshots
If applicable, add screenshots to help explain your problem.

Espressif-IDE Product Information:
*** Date: יום שני, 20 בינואר 2025 בשעה 11:02:15 שעון ישראל (חורף)

*** Platform Details:

Image

@github-actions github-actions bot changed the title Espressif IDE created an invalid .clang-format file Espressif IDE created an invalid .clang-format file (IEP-1404) Jan 20, 2025
@sigmaaa sigmaaa self-assigned this Jan 21, 2025
@sigmaaa
Copy link
Collaborator

sigmaaa commented Jan 21, 2025

Hi @emaayan,

Thank you for reporting this. We will replace it with the default .clang-format file from the cdt lsp editor plugin

@emaayan
Copy link
Author

emaayan commented Jan 21, 2025

Hi @emaayan,

Thank you for reporting this. We will replace it with the default .clang-format file from the cdt lsp editor plugin

you might want public something about known issue, in release notes about existing configurations that may contain invalid clangd-files they are gonna say they'll fix validations eclipse-cdt/cdt-lsp#348 (comment)

i'm over trying to actually fight with clang-format on how to make it NOT join lines on structs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants