Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check with the metadata generation bug case when yul: false and stackAllocation: true #1789

Open
kuzdogan opened this issue Dec 17, 2024 · 0 comments
Open

Check with the metadata generation bug case when yul: false and stackAllocation: true #1789

kuzdogan opened this issue Dec 17, 2024 · 0 comments
Labels
🪲 bug Something isn't working

Comments

@kuzdogan
Copy link
Member

In ethereum/solidity#15641 a bug was discovered that affects metadata.json generation. Apparently the metadata is wrong in the following cases:

Since 0.8.8 metadata produced in optimized compilation with Yul optimizer disabled will only allow recreating the same compilation if used via the same interface (Standard JSON vs CLI).

Since 0.8.21 metadata is wrong when compiling via Standard JSON with both optimizer.details.yul: false and optimizer.details.yulDetails.stackAllocation: true - the non-default state of the stackAllocation flag is not recorded.
@kuzdogan kuzdogan added the 🪲 bug Something isn't working label Dec 17, 2024
@kuzdogan kuzdogan moved this to Backlog in Sourcify Public Dec 17, 2024
@kuzdogan kuzdogan moved this from Backlog to Sprint - Candidates in Sourcify Public Dec 23, 2024
@marcocastignoli marcocastignoli moved this from Sprint - Candidates to Backlog in Sourcify Public Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🪲 bug Something isn't working
Projects
Sourcify Public
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kuzdogan