Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test out Solidity with subassemblies output #1859

Open
kuzdogan opened this issue Jan 17, 2025 · 0 comments
Open

Test out Solidity with subassemblies output #1859

kuzdogan opened this issue Jan 17, 2025 · 0 comments
Assignees

Comments

@kuzdogan
Copy link
Member

kuzdogan commented Jan 17, 2025

Solidity is developing the subAssemblyOffsets field in the compiler output to mark the nested contracts in the bytecode: https://github.com/ethereum/solidity/pull/15710/files

Nikola shared with me the latest binary. I tested out and found some mistakes, namely the deployedBytecode.subAssemblyOffset was a copy of the bytecode.subAssemblyOffset. They'll be fixing the issue and coming back to us.

Opening this issue to document the progress and in case we need to work on this when I was off.

Two input files I used:

DoubleFactory-input.json
FactoryTest-input.json

Outputs (with the above mistake) with the current binary 0.8.29-ci.2025.1.13+commit.d086ad9b:

DoubleFactory-output.json
FactoryTest-output.json

@kuzdogan kuzdogan self-assigned this Jan 17, 2025
@kuzdogan kuzdogan converted this from a draft issue Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Sprint - In Progress
Development

No branches or pull requests

1 participant