Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature-request: support key-signatures, especially for tuning symbols like up/down that aren't part of regular accidentals #13

Open
wolftune opened this issue Sep 11, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@wolftune
Copy link

wolftune commented Sep 11, 2024

In the up-down symbols in the Kite style, the ups and downs use ^ and v alongside whatever regular accidentals rather than the extra sharp/natural/flat symbols with tiny arrows. This separates the microtonal tuning indications from the standard accidental marks.

So, the ideal behavior would be that standard key signatures can be used, and the notes would follow them as usual. So, there's no need to show a natural just to show an up and down here.

Current status
I set keysig 0 0 # 0 0 # 0 and put in the normal D major signature in Musescore. I see it working correctly when there is no up/down arrow, but when the up/down arrow is added, I'm seeing it with the unnecessary extra sharp (which is redundant to the key signature). I should be seeing only the arrow with the sharp being inherited from the key signature.

I imagine this behavior is due to the assumption that the sharp symbol is part of the tuning indication, as it is with HEJI and the built-in extra accidentals in MuseScore

To Reproduce

  1. make a key signature with a # like D major
  2. use updown with symbols that do not use HEJI or similar but that use the ^/v approach
  3. reduce a note that is # in the key signature already by one arrow
  4. note that the sharp shows up instead of only the arrow showing up
TUNING CONFIG:
A4: 440
0c 1200*7/41c 1200*10/41c 1200*17/41c 1200*24/41c 1200*27/41c 1200*34/41c 2/1
bb b (1200*4/41c) # x
'ᴠᴠ' 'ᴠ' (1200*1/41c) 'ʌ' 'ʌʌ' // these are small capital V and IPA's inverted V

sec()
'bb' bb -1200*8/41c
'b' b -1200*4/41c
'##' x 1200*8/41c
'x' x 1200*8/41c
'#' # 1200*4/41c
'^' 'ʌ' 1200*1/41c // inverted V
'v' 'ᴠ' -1200*1/41c // small capital V


aux(0)
aux(1)
aux(2)

Environment:

  • OS: KDE Neon (built on Ubuntu)
  • MuseScore version: 3.6.2
  • Plugin version: 0.3.5

Screenshots
Screenshot_20240911_115219

@wolftune wolftune added the bug Something isn't working label Sep 11, 2024
@wolftune
Copy link
Author

wolftune commented Sep 11, 2024

I see that I can get a note with a single down and no # but that is for down-F-natural. That should be forcing a down symbol with a natural symbol to cancel the key signature. The natural does show correctly for plain-F-natural, but then for down-F-natural it disappears.

It appears that the interaction between the ups/downs and sharp/flat symbols is just not functioning, as though the up/down support is incomplete and not recognizing up/down as modifications of the sharp/flat.

@wolftune
Copy link
Author

related question/concern: is it possible (and if so how) to put ups and downs in a key signature? I wasn't clear on what the key signature notation is for that situation in order to test it.

@zhenlige
Copy link

zhenlige commented Dec 8, 2024

In this plugin, all accidentals are based on naturals, not the key signature.

@wolftune wolftune changed the title updowns showing arrow and sharp together despite key signature feature-request: support key-signatures Dec 9, 2024
@wolftune wolftune changed the title feature-request: support key-signatures feature-request: support key-signatures, especially for extra tuning symbols that aren't part of regular accidentals Dec 9, 2024
@wolftune
Copy link
Author

wolftune commented Dec 9, 2024

@zhenlige as I said in the original report, key-signatures are respected when the pitch is not shifted away from the default by the key signature. So, I understand that all accidentals are based on naturals, but key-signatures are still respected in the case of not showing any accidentals.

So, I changed it to a feature-request, but the idea is still important. Up/down accidentals that are separate arrows should not be based on naturals but on the key-signature.

@wolftune wolftune changed the title feature-request: support key-signatures, especially for extra tuning symbols that aren't part of regular accidentals feature-request: support key-signatures, especially for tuning symbols like up/down that aren't part of regular accidentals Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants