Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Long Dropdown Loading time when several values are selected by default #2980

Open
chapeaupaul opened this issue Jan 7, 2025 · 2 comments
Labels
bug Something isn't working customer request An Evidence customer has requested this

Comments

@chapeaupaul
Copy link

chapeaupaul commented Jan 7, 2025

Describe the bug

When working with many distinct values and dropdown filters, the loading time is impacted, making the dashboard impossible to use.
See loom video

Steps to Reproduce

https://www.loom.com/share/6d5e4bbee84c49d9a677b55c16111107

@chapeaupaul chapeaupaul added bug Something isn't working to-review Evidence team to review labels Jan 7, 2025
@github-actions github-actions bot added the customer request An Evidence customer has requested this label Jan 7, 2025
@archiewood archiewood changed the title [Bug]: Dropdown Loading time when several value [Bug]: Long Dropdown Loading time when several values are selected Jan 7, 2025
@archiewood archiewood changed the title [Bug]: Long Dropdown Loading time when several values are selected [Bug]: Long Dropdown Loading time when several values are selected by default Jan 7, 2025
@archiewood
Copy link
Member

Related to inlining all the default values in the array into the where clause

@nickfanion
Copy link
Contributor

nickfanion commented Jan 7, 2025

Would changing the behavior of selectAllByDefault or allowing a selectNoneByDefault that returns null or a value that lets us write SQL to skip the where clause when nothing is selected in a multi-select dropdown solve the performance issue? I'm experiencing a similar issue from a usability perspective. I'd rather have the multi select uncheck everything by default, which means return all data, and then filter it down with a few selections when needed.

However, the current behavior on first load with nothing selected causes the queries to hang:

Image

Making a selection, and then deselecting, still returns (select null where 0) without the comment, but now the queries process:

Image

@mcrascal mcrascal removed the to-review Evidence team to review label Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working customer request An Evidence customer has requested this
Projects
None yet
Development

No branches or pull requests

4 participants