Skip to content
This repository has been archived by the owner on Apr 17, 2019. It is now read-only.

Add buttons to "Open in Che" #67

Open
ALRubinger opened this issue Dec 7, 2018 · 8 comments
Open

Add buttons to "Open in Che" #67

ALRubinger opened this issue Dec 7, 2018 · 8 comments

Comments

@ALRubinger
Copy link
Contributor

Should be alongside the "View Source on GitHub" buttons/links wherever source is referenced.

TBD from the DevTools team what that link should point to.

@gastaldi
Copy link
Contributor

@gorkem can you advise on this with the necessary parameters?

@gorkem
Copy link

gorkem commented Dec 17, 2018

@l0rd @skabashnyuk Can we use devfile for this integration? It would be good if we can offer something that will not change soonish

@ALRubinger
Copy link
Contributor Author

Ping on this issue; we'd really like to be open newly-created codebases in Che, straight from the welcome app.

@l0rd
Copy link

l0rd commented Mar 13, 2019

@ALRubinger here is the devfile doc we have currently.

Basically you need to create a devfile, name it .devfile and put it at the root of a repository. Then the following link will open a corresponding workspace on https://che.openshift.io (assumed that oso infra is healthy): https://che.openshift.io/f?url=https://github.com/<org>/<repo>

@ALRubinger
Copy link
Contributor Author

Brilliant. Thanks for that URL format, @l0rd! Followup: does the devfile need to be in the root of the repo, or can it simply be in the root of the folder holding the code? At the moment we have a monorepo approach where frontend, backend, etc are all in the same repo separated by different folders. One repo may eventually support N runtimes.

So now it's on us to ensure all projects have a devfile. We can split this into 3 areas:

  1. Create Your Own - We make the devfile for each runtime. We may need to sync with the Che team for support status on each. Separate issue: https://github.com/fabric8-launcher/launcher-creator-backend/issues/150
  2. Import - Do we create a devfile on behalf of a user? Separate issue: https://github.com/fabric8-launcher/launcher-creator-backend/issues/151
  3. Examples - We need devfiles in each of these. Must work with the runtime teams to get these in. To be a separate issue. Separate issue: https://github.com/fabric8-launcher/launcher-planning/issues/209

@skabashnyuk
Copy link

@ALRubinger you can put .devfile in subfolders. However, in this case, you need to give a direct link to the devfile like : https://che.openshift.io/f?url=https://raw.githubusercontent.com/eclipse/che/master/.devfile

@quintesse
Copy link
Contributor

@skabashnyuk imagine that in a single repo you have a folder containing an Angular frontend and a folder containing a Vertx backend. Is htat something that can be described using the .devfile? And if so would that reside in a single file in the root of the project or does a parent/child system exist where each child folder could have its own .devfile with the parent file pointing to them?

(I'm trying to figure out if those files will have to be generated or if they can be mostly static)

@l0rd
Copy link

l0rd commented Mar 15, 2019

@quintesse one devfile describe one Che workspace. So it depends if you want one Che workspace with both applications or if you want to separate the Che workspaces. I would say that the choice depends on the team organization: will the code be own by the same team or by 2 separated teams?

For launchers I think a single .devfile should be preferred (i.e. one workspace with both applications).

For the devfile format refer to this issue here eclipse-che/che#12719 (PR to support has already been opened and should be merged in a few days).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants