Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] useSIWE() hook return union-typed as any #306

Open
volkyeth opened this issue Oct 12, 2023 · 3 comments · May be fixed by #317
Open

[BUG] useSIWE() hook return union-typed as any #306

volkyeth opened this issue Oct 12, 2023 · 3 comments · May be fixed by #317
Labels
bug Something isn't working

Comments

@volkyeth
Copy link

volkyeth commented Oct 12, 2023 •
edited
Loading

The useSIWE() hook return is union-typed as any:

connectkit/packages/connectkit/src/siwe/useSIWE.ts

Line 28 in 825f95e

| any => {

That kills all type inference when using it
@volkyeth volkyeth added the bug Something isn't working label Oct 12, 2023
@volkyeth volkyeth changed the title [BUG] useSIWE() hook union-typed as any [BUG] useSIWE() hook return union-typed as any Oct 12, 2023
@alex-grover alex-grover linked a pull request Nov 8, 2023 that will close this issue
Open
@ian-os
Copy link

ian-os commented Nov 22, 2023 •
edited
Loading

Running into the same issue, tying is completely bricked for useSIWE() hook.

https://github.com/family/connectkit/blame/main/packages/connectkit/src/siwe/useSIWE.ts#L28C7-L28C7

Ping @lochie

CleanShot 2023-11-22 at 15 54 38@2x

@ian-os ian-os mentioned this issue Nov 22, 2023
Closed
@ian-os
Copy link

ian-os commented Nov 22, 2023

Created PR fix: #322

@lochie @volkyeth

@alex-grover
Copy link
Contributor

@ian-os changing the return types breaks a few other places. I have a fix for those as well in #317

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove any from return types alex-grover/connectkit
fix useSIWE() return typing, no any
3 participants
@volkyeth @alex-grover @ian-os