Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop Patching in Broken Image-Base Behavior in Flexdll #106

Open
EmmaJaneBonestell opened this issue Feb 19, 2022 · 1 comment
Open

Stop Patching in Broken Image-Base Behavior in Flexdll #106

EmmaJaneBonestell opened this issue Feb 19, 2022 · 1 comment

Comments

@EmmaJaneBonestell
Copy link

EmmaJaneBonestell commented Feb 19, 2022

Since September of 2020, flexdll no longer passes image-base because it will create DLLs/plugins with relocations too far to be loaded.

ocaml/flexdll#50
ocaml/flexdll#89
ocaml/ocaml#10351

OCaml versions 4.12.1 and newer need to stop passing this flag, but the inline-flexdll.patch is outdated and still implements this behavior on new versions of OCaml.

@fdopen
Copy link
Owner

fdopen commented Mar 13, 2022

The problem with the new solution is that it requires changes to external stub code. When the new OCaml version appeared, of course, no one had adapted the source code yet. I left the hack so that everything wouldn't stop working all at once. But you are right. Meanwhile some time has passed, I will release OCaml 4.14/flexlink 0.40 without it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants