Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't report to Sentry when a module was restarted due to inactivity #599

Open
sentry-io bot opened this issue Sep 16, 2024 · 1 comment
Open

Don't report to Sentry when a module was restarted due to inactivity #599

sentry-io bot opened this issue Sep 16, 2024 · 1 comment

Comments

@sentry-io
Copy link

sentry-io bot commented Sep 16, 2024

Sentry Issue: STATION-CORE-BTM

AbortError: This operation was aborted
  File "C:/Users/leise/AppData/Local/Programs/Filecoin%20Station/resources/core/lib/zinnia.js", line 283, in Timeout.?

IIUC, this error is triggered when we detect that a module was inactive for 5 minutes. This error is not actionable; I argue we should not report it to Sentry at all.

@bajtos
Copy link
Member

bajtos commented Sep 16, 2024

The relevant source code:

core/lib/zinnia.js

Lines 275 to 287 in 0cf7635

let timeoutId
const resetTimeout = () => {
clearTimeout(timeoutId)
timeoutId = setTimeout(() => {
onActivity({
type: 'error',
message: `${capitalize(module)} has been inactive for 5 minutes, restarting...`
})
controller.abort()
}, 5 * 60 * 1000)
}
resetTimeout()
signal.addEventListener('abort', () => clearTimeout(timeoutId))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant