Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

null data fails when setting data in a class #44

Open
iampersistent opened this issue Mar 5, 2018 · 5 comments
Open

null data fails when setting data in a class #44

iampersistent opened this issue Mar 5, 2018 · 5 comments

Comments

@iampersistent
Copy link
Contributor

If you have a null property, currently the transformer will try to insert an empty value into the setter method.

AbstractObjectTransformer should be updated so allowUntransform returns false when the value is empty/null.

@iampersistent
Copy link
Contributor Author

iampersistent commented Mar 5, 2018

AbstractEnumTransformer needs to be handled the same way

@ruskiyos
Copy link
Contributor

ruskiyos commented Mar 5, 2018

What do you mean by null property? Like 'property' => null?

@iampersistent
Copy link
Contributor Author

yes

@iampersistent
Copy link
Contributor Author

iampersistent commented Mar 5, 2018

I'll take care of this, I just don't have the time ATM to write the tests. I figured it was better to mention it needs work, just in case someone else runs into it.

@ruskiyos
Copy link
Contributor

ruskiyos commented Mar 5, 2018

ohh. i thought you meant when we define transformers (null in the place of transformer class). you mean the actual model lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants