Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Status page Delete incident confirmation modal appears at bottom of page #20

Closed
sedan07 opened this issue Feb 6, 2021 · 1 comment
Closed

Status page Delete incident confirmation modal appears at bottom of page #20

sedan07 opened this issue Feb 6, 2021 · 1 comment
Assignees
@sedan07
Labels
bug Something isn't working
Milestone
2.5

Comments

@sedan07
Copy link

sedan07 commented Feb 6, 2021

The confirmation modal window appears more as a white box at the bottom of the page rather than a modal over the top of other elements. Either this should take you to the dashboard and trigger the delete action or the confirmation should appear correctly as a modal.

Tested in Chrome and FF.
@sedan07 sedan07 added this to the 2.5 milestone Feb 6, 2021
@sedan07 sedan07 added the bug Something isn't working label Feb 6, 2021
@sedan07 sedan07 self-assigned this Feb 8, 2021
sedan07 added a commit that referenced this issue Feb 8, 2021
@sedan07
Ignore modal styles "swal2" when purging unused CSS #20
5ed3464
sedan07 added a commit that referenced this issue Feb 8, 2021
@sedan07
Merge pull request #27 from fiveai/20-broken-delete-modal
ac36057 
Ignore modal styles "swal2" when purging unused CSS #20
@sedan07
Copy link
Author

sedan07 commented Feb 9, 2021

CSS added back in. Now works as expected in Chrome and FF.

@sedan07 sedan07 closed this as completed Feb 9, 2021
@ghost ghost mentioned this issue Sep 30, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sedan07 sedan07

Labels
bug Something isn't working
Projects
None yet
Milestone
2.5
Development

No branches or pull requests
1 participant
@sedan07