Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: --build-shell parameter stops after configuration not download/unpackaging #479

Open
2 tasks done
llothar opened this issue Jul 4, 2022 · 0 comments · May be fixed by #508 or #625
Open
2 tasks done

[Bug]: --build-shell parameter stops after configuration not download/unpackaging #479

llothar opened this issue Jul 4, 2022 · 0 comments · May be fixed by #508 or #625

Comments

@llothar
Copy link

llothar commented Jul 4, 2022 •
edited
Loading

Checklist

  • I agree to follow the Code of Conduct that this project adheres to.
  • I have searched the issue tracker for a bug that matches the one I want to file, without success.

flatpak-builder version

1.2.2

Flatpak version

1.12.7

How to reproduce

Create a module that fails in the configuration step

Expected Behavior

Just as described in the documentation for --build-shell

"Extract and prepare the sources for the named module,
and then start a shell in a sandbox identical to the one flatpak-builder
would use for building the module. This is useful to debug a module."

Actual Behavior

It doesnt stop after downloading and extracting the sources, but
AFTER the configuration step. And if the configuration step fails there is no
way to get into the build shell and see what the problem is

Either this or the documentation is wrong.
But an implementation as in the documentation makes much more sense.

Additional Information

No response
@llothar llothar added the bug label Jul 4, 2022
koko-ng added a commit to koko-ng/flatpak-builder that referenced this issue Jan 2, 2023
@koko-ng
Run shell before the start of the build
8a2f8e6 
Fixes flatpak#479
@koko-ng koko-ng linked a pull request Jan 2, 2023 that will close this issue
Open
@TingPing TingPing removed the bug label Apr 28, 2023
nbenitez added a commit to nbenitez/flatpak-builder that referenced this issue Nov 23, 2024
@nbenitez
Don't ignore --build-shell option when configuration fails
7c18868 
--build-shell is supposed to help in debbuging problems
for modules, that may be a failure to build, to configure,
etc.

So it doesn't make much sense that if the configuration
step fails we ignore the --build-shell option, which the
developer probably use it to debug that configure problem.

Fixes flatpak#479
@nbenitez nbenitez linked a pull request Nov 23, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@TingPing @llothar