Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: unmount command should be fusermount3 when building only against fuse3 #486

Open
2 tasks done
tinywrkb opened this issue Aug 18, 2022 · 2 comments · May be fixed by #616
Open
2 tasks done

[Bug]: unmount command should be fusermount3 when building only against fuse3 #486

tinywrkb opened this issue Aug 18, 2022 · 2 comments · May be fixed by #616

Comments

@tinywrkb
Copy link

Checklist

  • I agree to follow the Code of Conduct that this project adheres to.
  • I have searched the issue tracker for a bug that matches the one I want to file, without success.

flatpak-builder version

1.2.2

Flatpak version

1.12.7

How to reproduce

  1. Build flatpak-builder only against fuse3, without fuse2.
  2. No libfuse.2.so in the system, nor fusermount.
  3. Starting building an application with flatpak-builder, and stop midway.

Expected Behavior

The temporary rofiles mount inside state-dir/rofiles/ should be unmounted.

Actual Behavior

flatpak-builder does not unmount the temporary rofiles mount on exit, and can't unmount it when starting a new build run.

Additional Information

Distro: Arch Linux.

Creating a fusermount symlink to fusermount3 fixes the issue, and it looks like that the unmount command in src/builder-context.c should be set as fusermount3 if only fuse3 support was enabled.
@tinywrkb tinywrkb added the bug label Aug 18, 2022
@TingPing TingPing removed the bug label Apr 28, 2023
@nanonyme
Copy link
Contributor

While this is not a bug, it seems like an important feature. Fedora has started hitting this with their fuse2 deprecation.

@smcv
Copy link
Collaborator

smcv commented Aug 19, 2024

The equivalent of flatpak/flatpak@2cb17b4 is probably the best solution to this.

TingPing added a commit that referenced this issue Aug 19, 2024
@TingPing
Add ability to set custom fusermount path
615635b 
This is only exposed in Meson as Autotools isn't recommended.

This also removes the 'fuse' option as it seems redundant.

Fixes #486
@TingPing TingPing linked a pull request Aug 19, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add ability to set custom fusermount path flatpak/flatpak-builder
4 participants
@nanonyme @TingPing @smcv @tinywrkb