Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text not displaying properly #2

Open
madb1lly opened this issue Jul 22, 2020 · 17 comments
Open

Text not displaying properly #2

madb1lly opened this issue Jul 22, 2020 · 17 comments

Comments

@madb1lly
Copy link

Hi @flatsiedatsie,

On Fenix and Fennec Firefox on Android the text isn't displaying properly for me:
Screenshot_1595445768521
Nothing obvious in the internal logs and I've got debug logs on.

Cheers 🙂

@flatsiedatsie
Copy link
Owner

Thanks. Probably just a CSS issue. I'll look into it.

@madb1lly
Copy link
Author

Hi @flatsiedatsie,

After more checking I can see that this is only happening with the native WebThings connected via the things-url-adapter. All the WebThings are written with the Arduino libraries but of various versions.

Maybe there's a problem with the adapter, the library or my code?

Cheers 🙂

@flatsiedatsie
Copy link
Owner

If it only happens with one type of device, then that's strange. Other things do have a normally populated list?

It could be that the thing or property ID's of those devices are leading to a problem. They may have stange characters in them, for example. Could you give an example of what the URL bar looks like when you look at one of these devices? And what are the properties supposed to be?

@madb1lly
Copy link
Author

Hi @flatsiedatsie,

This is an example of one: /things/http---192.168.1.43-things-bme280wbattery
And another: /things/http---192.168.1.39-things-heater

Looking at that, the problem is probably the full stops "." or the dashes "-" as your extension might not be expecting to see code like that.

Cheers 🙂

@flatsiedatsie
Copy link
Owner

Yes that might be it.

@flatsiedatsie
Copy link
Owner

I did a test by creating a device with dots in the thing ID, property ID and titles. And it worked just as normal.

@madb1lly
Copy link
Author

Hi @flatsiedatsie,
Then it might be an issue with how the Arduino library presents the names of thing properties, maybe @mrstegeman has an idea about it.
Cheers 🙂

@flatsiedatsie
Copy link
Owner

Perhaps the addon still sends 'name' instead of 'title'.

@flatsiedatsie
Copy link
Owner

Try clearing your browser's cache too.

@mrstegeman
Copy link
Contributor

Older versions of the library used label rather than title. Perhaps that’s the issue?

@flatsiedatsie
Copy link
Owner

A new version has been released that, in theory, should also check for 'label' if it can't find a 'title'.

@madb1lly
Copy link
Author

Hi @flatsiedatsie,

The new version brings improvement! There is now text for these native WebThings' properties but it all just says "unknown".

My latest WebThings are from about two months ago which i think is after the change from title to label isn't it @mrstegeman? My code is here: https://github.com/madb1lly/ESP8266-BME280-WebThing/blob/master/bme280wbattery.ino

Cheers 🙂

@madb1lly
Copy link
Author

madb1lly commented Dec 4, 2020

Hi @flatsiedatsie,

For info, the Macros extension doesn't show the thing properties as Unknown, so maybe you'll find the answer in that code.

Cheers 🙂

@flatsiedatsie
Copy link
Owner

Macros uses javascript instead of python

@madb1lly
Copy link
Author

madb1lly commented Dec 7, 2020

Hello @flatsiedatsie, okay, but you can ignore me anyway, I got mixed up - Macros also shows "unknown" for these properties on these native webthings.

@flatsiedatsie
Copy link
Owner

If two addons do this, then it's a pattern. Perhaps @mrstegeman should be informed.

@mrstegeman
Copy link
Contributor

You should log what you're passing into each new Option() call. I'm guessing the first field is null/undefined/empty.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants