Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌓 moon functions 🌗 #1

Open
laduke opened this issue Oct 30, 2018 · 1 comment
Open

🌓 moon functions 🌗 #1

laduke opened this issue Oct 30, 2018 · 1 comment
Labels
enhancement

Comments

@laduke
Copy link

laduke commented Oct 30, 2018

Hello! I was looking into porting the moon functions from mourner/suncalc. Would you want those in this repo?

I've done the moon position function so far, and I noticed to you add PI to the azimuth in the rust version. Just curious why; I don't know anything about astronomy math :)
@flosse
Copy link
Owner

flosse commented Oct 30, 2018

Hello! I was looking into porting the moon functions from mourner/suncalc. Would you want those in this repo?

yes, that's great :)

I've done the moon position function so far, and I noticed to you add PI to the azimuth in the rust version. Just curious why

to convert between radian and degree

@laduke laduke mentioned this issue Nov 2, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Moon
3 participants
@laduke @flosse and others