Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ESBuild 0.18.0 #470

Closed
cmcnicholas opened this issue Jun 11, 2023 · 6 comments
Closed

Support ESBuild 0.18.0 #470

cmcnicholas opened this issue Jun 11, 2023 · 6 comments
Labels
bug Something isn't working

Comments

@cmcnicholas
Copy link

Describe the bug

package.json defines peer dep for esbuild to < 0.18

To Reproduce

Try to update to 0.18.0 esbuild.

Expected behavior

To npm install correctly.

Screenshots or Logs

npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR! 
npm ERR! While resolving: [email protected]
npm ERR! Found: [email protected]
npm ERR! node_modules/esbuild
npm ERR!   dev esbuild@"^0.18.0" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer esbuild@">=0.8 <0.18" from [email protected]
npm ERR! node_modules/serverless-esbuild
npm ERR!   dev serverless-esbuild@"^1.43.1" from the root project
npm ERR! 
npm ERR! Conflicting peer dependency: [email protected]
npm ERR! node_modules/esbuild
npm ERR!   peer esbuild@">=0.8 <0.18" from [email protected]
npm ERR!   node_modules/serverless-esbuild
npm ERR!     dev serverless-esbuild@"^1.43.1" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

Versions (please complete the following information):

  • OS: Windows
  • Serverless Framework Version: ^3.27
  • Plugin Version: ^1.43.1

Additional context

N/A

@cmcnicholas cmcnicholas added the bug Something isn't working label Jun 11, 2023
@fm-sz
Copy link
Contributor

fm-sz commented Jun 22, 2023

This package also has a dependency to https://github.com/pradel/esbuild-node-externals

I have submitted a PR there to raise the allowed esbuild version: pradel/esbuild-node-externals#43

Without this change, the esbuild version also can't be upgraded in this package.

@fm-sz
Copy link
Contributor

fm-sz commented Jun 22, 2023

After the package https://github.com/pradel/esbuild-node-externals was now upgraded with the merge of pradel/esbuild-node-externals#43, I tried to upgrade the allowed esbuild dependency here as well: #473

However I ran into some issues with the incremental option. I don't fully understand how to solve these yet.
Help, inspiration and comments in the PR are highly appreciated.

@acommodari
Copy link

Hey just wondering what the status of this issue is? Would love to know if theres an ETA for esbuild 0.18

@vicary
Copy link

vicary commented Jul 18, 2023

Gently pinging @floydspace, what is your recommended approach with the incremental option in #473?

@Ilia-TheNetworkFirm
Copy link

Hi guys, looks like esbuild-node-externals have recently published a new release: https://github.com/pradel/esbuild-node-externals/releases/tag/v1.9.0

@floydspace
Copy link
Owner

closed by #487
thanks to @ZachLeviPixel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants