Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indirect dependency marked as external missing in package #511

Open
jer-sen opened this issue Dec 7, 2023 · 1 comment
Open

Indirect dependency marked as external missing in package #511

jer-sen opened this issue Dec 7, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@jer-sen
Copy link

jer-sen commented Dec 7, 2023

Describe the bug
My code import a module ssh2-sftp-client which has module ssh2 as a dependency which is listed in esbuild.config.ts externals (contains .node files).
ssh2 is in .esbuild/.build folder but missing in final zip package.

To Reproduce
Add dependencies ssh2-sftp-client and ssh2, add ssh2 to externals, and package a file importing ssh2-sftp-client.

Expected behavior
ssh2 present in package.

Screenshots or Logs
NA

Versions (please complete the following information):

Additional context
Is ssh2 is imported from directly from the file importing ssh2-sftp-client, then everything is ok. That's my workaround...

@jer-sen jer-sen added the bug Something isn't working label Dec 7, 2023
@a-r-d
Copy link

a-r-d commented May 9, 2024

ok im hitting this too now, externals is being ignored or something

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants