Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Add terms and conditions button in Sign Up VC #532

Closed
wants to merge 1 commit into from
Closed

Feat: Add terms and conditions button in Sign Up VC #532

wants to merge 1 commit into from

Conversation

baquer
Copy link
Member

@baquer baquer commented Mar 21, 2019

Fixes #531

Changes:

  1. Add the terms button in signup VC.
  2. Add functions for opening the URL.

Screenshots for the change:

Screenshot 2019-03-21 at 11 00 16 PM

@baquer
Copy link
Member Author

baquer commented Mar 21, 2019

@chashmeetsingh, @jogendra, Please review the PR.

@jogendra
Copy link
Member

jogendra commented Apr 3, 2019

I don't think we need it here. @chashmeetsingh your views?

@chashmeetsingh
Copy link
Member

I am not sure either because I have seen T&C on both login and signup pages before.

jogendra
jogendra suggested changes May 23, 2019
View reviewed changes
Copy link
Member

@jogendra jogendra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Closing the PR as of now. In future when we need it, feel free to open the PR again :)

@jogendra jogendra closed this May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jogendra jogendra jogendra requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add terms and conditions link button in SignUpVC.
3 participants
@baquer @jogendra @chashmeetsingh