Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this project being maintained? #29

Open
ktkaufman03 opened this issue Mar 4, 2024 · 2 comments
Open

Is this project being maintained? #29

ktkaufman03 opened this issue Mar 4, 2024 · 2 comments

Comments

@ktkaufman03
Copy link

Hi,

I've been working on some Rust IIO applications and noticed that this library - while still usable today - hasn't been updated in a while. I've been doing some work to bring it up to speed with the things I need to do, but I'm wondering if you still have time to review and accept contributions or if it's best that I continue on my own.

If you'd like to discuss things privately for any reason, I can be reached at [email protected].

Thanks!

@fpagliughi
Copy link
Owner

What? I just updated it last year :-)

Yes, I still consider this in my active rotation, and am using it in production. So I can vouch for the quality of what's there (it keeps running), if not the couple of missing features that I haven't gotten to yet.

The most obvious omission is the lack of a writable buffer for output. I didn't personally need D/A capabilities, so kept putting it off. See PR #27 for a discussion. Unfortunately, the D/A boards I ordered didn't arrive, so I do need get some real-world hardware to test out some of that work that was started.

But, beyond that, open an issue or put up some PR's if you've started some work. I would just ask that each PR be fairly targeted so we can consider and discuss each independently.

Note that the latest code is in the develop branch, so please PR against that, not master.

The other two things I had on my vague TODO list:

  • Figure out the thread safety guarantees of the underlying C library as mentioned in Thread safety #16, and update this lib accordingly.
  • Improve on the -sys FFI layer to possibly chose between a few target versions of the C lib, and use bindgen directly in the build as an optional Cargo feature (see the work started in develop)

@ktkaufman03
Copy link
Author

Sounds good. One of the first big things I did was rework the -sys library (and the main crate too) so it can work on Windows. I'll see about splitting things up and submitting some PRs soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants