-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Containers with relative positioning to solve overflow problem #102
Comments
There are many cases where you have more then 1 table. we can't set relative postioning so i have added option to set primary table. table set as primary will span accross multiple pages and will have dynamic height. Actual Fix for this issue is frappe#102 but this is a workaround for now.
* fix: option to set primary table There are many cases where you have more then 1 table. we can't set relative postioning so i have added option to set primary table. table set as primary will span accross multiple pages and will have dynamic height. Actual Fix for this issue is #102 but this is a workaround for now. * fix: update schema version for primary table As we can't guess for the user which is primary table, we need to apply logic only to new schema without changing old behavior.
any more update here @maharshivpatel eagerly waiting for fixes . this is really critical |
@qsarthi can you share your use case ? it will help with validating ideas as well. |
Basically in our case we have bundled products . For Delivery note Printing (applies to even other doc types) , we need to print table of bundled items and the table of individual item list (packed list) ..along with some comments like certain items have some minor issues... Currently i can set only one table as Primary ... One of Option you can consider is to allow having multiple primary/flex size blocks.. (not only table but even other types). if too complex..for short time , may be allow a new type "page break" and allow one primary type in each page... |
🎉 This issue has been resolved in version 1.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
closing as most of this is solved. if you face any specific issue please create a separate issue. Thank you |
Biggest Limitation of Print Designer for now is Everything is Absolute positioned so we can't design formats that have huge difference it Information and or want to designer multi page formats.
Read this to understand the problem right now all elements in print designer are
out of flow
https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_flow_layout/In_flow_and_out_of_flow
Solution:
create a structure with combination of in_flow and out_of_flow elements with right balance so we can create as many pages as required.
biggest issue is to find a way to structure that it doesn't limit users ability to move elements everything that user have right now and add it in a way that it doesn't ruin the user experience.
The text was updated successfully, but these errors were encountered: