Support an instance mode for node-html-to-image #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**This is a breaking API change (for now)** node-html-to-image's default export is now a function which returns an instance object with a render() method which is the old nodeHtmlToImage() functionality. The reason for doing this is to allow us to instantiate a single 'image maker' object that we call render() on multiple times and reuse the same puppeteer cluster. In addition, * Update the type definitions. * Use Cluster.execute() instead of Cluster.queue() plus Cluster.idle() as this will allow better use in concurrent situations. We will only wait for our jobs to finish rather than for the entire cluster to go idle. Fixes frinyvonnick#80
|
Hi, we really need this feature. It would be great if that PR can be merged. |
|
Hi @michael-eckhart-woellkart this PR does not work. Feel free to read the associated issue and propose a PR that fixes it 👌 |
|
I close this PR because I did not get any answer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking API change (for now)
node-html-to-image's default export is now a function which returns an
instance object with a render() method which is the old
nodeHtmlToImage() functionality. The reason for doing this is to allow
us to instantiate a single 'image maker' object that we call render() on
multiple times and reuse the same puppeteer cluster.
In addition,
as this will allow better use in concurrent situations. We will only
wait for our jobs to finish rather than for the entire cluster to go
idle.
Fixes #80