Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search result highlighting breaks markdown rendering #612

Open
lukasrad02 opened this issue Aug 12, 2024 · 5 comments
Open

Search result highlighting breaks markdown rendering #612

lukasrad02 opened this issue Aug 12, 2024 · 5 comments
Assignees
Labels
[T] bug Something isn't working

Comments

@lukasrad02
Copy link
Contributor

#557 added highlighting of the search term in search results. This could break the rendering of search results if the term occurs in identifiers (e.g. internal links) instead of normal text.

Steps to reproduce

  • Create two information pages. Let x, y be their IDs
  • On the first page, create an internal link to the second page like [Second page](page:y) and publish this change
  • Search for the numeric value of ID y
  • There is an internal server error, since y has been replaced by **y**, which cannot be casted to an int
@lukasrad02 lukasrad02 added the [T] bug Something isn't working label Aug 12, 2024
@corvin-koegler
Copy link

Hello there!

@abc013
Copy link
Contributor

abc013 commented Oct 22, 2024

General Kenobi!

@jeriox
Copy link
Contributor

jeriox commented Oct 22, 2024

btw the ordering of results is also not correct, in case you want to tackle this as well

@corvin-koegler
Copy link

btw the ordering of results is also not correct, in case you want to tackle this as well

image

Looks like they are sorted by creation date. What is the intended behaviour?

@jeriox
Copy link
Contributor

jeriox commented Oct 22, 2024

image
not really, they are all over the place. Intended behaviour would be to use the minutes date for minutes. It would probably be best to sort information pages to the front to make them visible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[T] bug Something isn't working
Development

No branches or pull requests

4 participants