Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] - Allow to change compliance_ref_link in a loaded controller #127

Open
firesurfer opened this issue May 25, 2023 · 2 comments
Labels
enhancement New feature or request ROS2

Comments

@firesurfer
Copy link

Problem statement and motivation

Currently it is not possible to change to compliance_ref_link in an already loaded controller as it is not possible to reconfigure a controller once it is configured ( as far as know - see ros-controls/ros2_control#1033)

For larger setups with multiple robot arm which also have multiple tools which have to be compliant at some point the current solution of defining a controller per compliant link becomes messy quite easily.

Therefore it would be nice to just have a compliance controller per arm and being able to change to ref_link.

Goal of this feature

Being able to set the compliance_ref_link , deactivate -> active the controller and then use the changed ref_link

Approach and next steps

Simply move:

m_compliance_ref_link = get_node()->get_parameter("compliance_ref_link").as_string();

into the beginning of on_activate.

If desired I can also provide a PR for that.

@stefanscherzinger stefanscherzinger added the enhancement New feature or request label May 25, 2023
@stefanscherzinger
Copy link
Contributor

@firesurfer

Thanks for this feature request. I like the idea and will have a look.

@firesurfer
Copy link
Author

@stefanscherzinger Great that you see it the same way. Give that I need this feature rather sooner then later I will try to workout a solution and create a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ROS2
Projects
None yet
Development

No branches or pull requests

2 participants