Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Occurrence search #826

Closed
MortenHofft opened this issue Jan 9, 2025 · 2 comments
Closed

Occurrence search #826

MortenHofft opened this issue Jan 9, 2025 · 2 comments
Assignees
Labels
bug Something isn't working HP parity Required to replace the hosted portals

Comments

@MortenHofft
Copy link
Member

recorded by track by recordedName not working as there is no guaruantee that they are not repeated

hook.js:608 Warning: Encountered two children with the same key, `, A.`. Keys should be unique so that components maintain their identity across updates. Non-unique keys may cause children to be duplicated and/or omitted — the behavior is unsupported and could change in a future version. Error Component Stack
    at span (<anonymous>)
    at InlineLineClamp (inlineLineClamp.tsx:7:35)
    at SetAsFilterList (setAsFilterList.tsx:13:3)

example 3057853303 "recordedBy": [ "Hillman", ", A.", "Carter", ", A." ],

@MortenHofft MortenHofft added bug Something isn't working HP parity Required to replace the hosted portals labels Jan 9, 2025
@danielvdm2000
Copy link
Contributor

Is the cell formatted incorrectly?

Should "Hillman", ", A.", "Carter", ", A." really be displayed as four different values that all can be set as a filter?

@MortenHofft

@MortenHofft
Copy link
Member Author

MortenHofft commented Jan 15, 2025

In this case it is clearly a data issue. Either the data provider or interpretation has messed something up. It was just the example I stumbled on. But it seems reasonable that we cannot rely on names being unique. If that is a requirement for the UI, then we should filter them first.

fwiw: provided by publisher as "recordedBy": "Hillman|, A.|Carter|, A.", so yes, four values. And yes it is probably a mistake

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working HP parity Required to replace the hosted portals
Projects
None yet
Development

No branches or pull requests

2 participants