Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ReaderObservable.chainTaskK type signature #64

Open
lingard opened this issue Jul 21, 2021 · 1 comment · May be fixed by #65
Open

ReaderObservable.chainTaskK type signature #64

lingard opened this issue Jul 21, 2021 · 1 comment · May be fixed by #65
Labels
accepting PRs bug

Comments

@lingard
Copy link

lingard commented Jul 21, 2021

fp-ts-rxjs/src/ReaderObservable.ts

Lines 131 to 133 in 40a4e4f

export const chainTaskK = <A, B>(
f: (a: A) => Observable<B>
): (<R>(ma: ReaderObservable<R, A>) => ReaderObservable<R, B>) => chain(a => fromObservableK(f)(a))

Is the type signature of this function correct? I would expect the function passed to chainTaskK to return a Task not an Observable.
@lingard lingard changed the title ReaderObservable chainTaskK ReaderObservable.chainTaskK type signature Jul 21, 2021
@mlegenhausen
Copy link
Collaborator

mlegenhausen commented Jul 21, 2021 •
edited
Loading

Totally right, or this should be renamed to chainObservableK

@lingard lingard linked a pull request Jul 21, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accepting PRs bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix ReaderObservable.chainTaskK and add chainObservableK lingard/fp-ts-rxjs
2 participants
@mlegenhausen @lingard