Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple modal widths #58

Open
mrozbarry opened this issue Feb 8, 2017 · 1 comment
Open

Allow multiple modal widths #58

mrozbarry opened this issue Feb 8, 2017 · 1 comment

Comments

@mrozbarry
Copy link

It would be nice to be able to set a small/medium/large width on modals, or allow some style overrides for the width.

@gdotdesign
Copy link
Owner

Modals fit their contents, they have only max-width: 80vw and max-height: 80vh set as constraints which can be removed.

We can add optional width and height in it's ViewModel like so:

type alias ViewModel msg =
  { contents : List (Html.Html msg)
  , footer : List (Html.Html msg)
  , address : (Msg -> msg)
  , title : String

  , width : Maybe Float
  , height : Maybe Float
  }

But I don't know if it's justified enough to do so, because the width and height of ui-modal-wrapper can be set easily with CSS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants