Fix bug when loading geojson layers in notebook and update notebook test #305
+15
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
gjmooney
force-pushed
the
geojson_notebook_fix
branch
from
02c6f93 to
28d32da
Compare
|
please update snapshots |
|
Integration tests report: appsharing.space |
|
please update snapshots |
gjmooney
force-pushed
the
geojson_notebook_fix
branch
from
9372342 to
89bd147
Compare
|
please update snapshots |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix bug when loading geojson layers in a notebook. Previously only the first feature would be added to the map.
Before:
After:
This also updates the notebook test to be more zoomed out so (hopefully) labels on the map don't cause the screenshot tests to fail.
Checklist
Failing lint checks can be resolved with:
pre-commit run --all-filesjlpm run lint📚 Documentation preview: https://jupytergis--305.org.readthedocs.build/en/305/
💡 JupyterLite preview is available from the doc, by clicking on