New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce code by refining LyricsWithModels #49

Open

georgid opened this issue Oct 4, 2017 · 0 comments

Assignees

Labels

Milestone

Clean up and refa...

Owner

georgid commented Oct 4, 2017

The LyricsWithModels is not needed for NeuralNEtwork, so Baseclass is used for DNN, add padded silicce method. As result:

LyricsWithModelsBase is used for DNN. LyricsWithModelsCNN._linkTomodels and
LyricsWithModelsBase._linkTomodels do not make sense.

maybe remove lyrics With models in general.

then reduce if statement in SecionLink.loadSmallAudioFragment()

georgid added dev_ops refactoring labels

georgid self-assigned this

georgid added enhancement and removed dev_ops labels

georgid removed the enhancement label

georgid added this to the Clean up and refactor cases lyrics milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment