Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DipoleWidget.py #14

Open
3 tasks
lheagy opened this issue Jul 25, 2016 · 0 comments
Open
3 tasks

DipoleWidget.py #14

lheagy opened this issue Jul 25, 2016 · 0 comments

Comments

@lheagy
Copy link
Member

lheagy commented Jul 25, 2016

  • add an if __name__ == '__main__': at the end so that the script can be run as-is (then we can add testing to it eg. if it runs, it passes, similar to SimPEG Examples)
  • could you add some comments / minimal docstrings to give a bit more insight as to what each method is doing and what some of the important parameters are? (eg. it is not immediately evident what the first x, y, z are... are they source location?, measurement location?)
  • some of the title matching, function matching could be better handled with dictionaries instead of a series of if statements (not as high of priority as the other 2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants