You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
add an if __name__ == '__main__': at the end so that the script can be run as-is (then we can add testing to it eg. if it runs, it passes, similar to SimPEG Examples)
could you add some comments / minimal docstrings to give a bit more insight as to what each method is doing and what some of the important parameters are? (eg. it is not immediately evident what the first x, y, z are... are they source location?, measurement location?)
some of the title matching, function matching could be better handled with dictionaries instead of a series of if statements (not as high of priority as the other 2)
The text was updated successfully, but these errors were encountered:
if __name__ == '__main__':
at the end so that the script can be run as-is (then we can add testing to it eg. if it runs, it passes, similar to SimPEG Examples)x
,y
,z
are... are they source location?, measurement location?)if
statements (not as high of priority as the other 2)The text was updated successfully, but these errors were encountered: