feat: add custom-timeout-values-for-requester-method #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolznz
reviewed
Jan 21, 2025
| @@ -819,6 +825,7 @@ export class NWCClient { | |||
| nip47Method: Nip47SingleMethod, | |||
| params: unknown, | |||
| resultValidator: (result: T) => boolean, | |||
| timeoutValues?: Nip47TimeoutValues, | |||
There was a problem hiding this comment.
Less important, but can this also be added to the executeMultiNip47Request method?
rolznz
reviewed
Jan 21, 2025
| @@ -544,6 +549,7 @@ export class NWCClient { | |||
| "get_info", | |||
| {}, | |||
| (result) => !!result.methods, | |||
| { replyTimeout: 10000 }, | |||
There was a problem hiding this comment.
Originally you also wanted to be able to customize this on a per-request basis right? but I guess this is ok.
I would probably also apply this smaller timeout to other non-payment requests (get balance, get budget, list transactions, etc.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #295