Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Express v5 #13674

Open
mydea opened this issue Sep 12, 2024 · 6 comments
Open

Support Express v5 #13674

mydea opened this issue Sep 12, 2024 · 6 comments
Assignees
Labels
Package: node Issues related to the Sentry Node SDK Package-Meta: OpenTelemetry

Comments

@mydea
Copy link
Member

mydea commented Sep 12, 2024

Description

It seems that Express v5 is actually close: https://github.com/expressjs/express/releases/tag/v5.0.0

We should ensure we have support for this. This means ensuring that this is supported upstream in the OTEL instrumentation.

@mydea mydea added the Package: node Issues related to the Sentry Node SDK label Sep 12, 2024
@joergbaier
Copy link

I would appreciate sentry supporting express v5. Having support here would help express finally get v5 released under the "latest" tag. 🙏

Sentry also integrates with GQL and I believe the @apollo/server + express pairing is fairly popular.
apollographql/apollo-server#7928

@timfish
Copy link
Collaborator

timfish commented Sep 19, 2024

Otel PR:

@AbhiPrasad
Copy link
Member

@kvjoshi
Copy link

kvjoshi commented Jan 21, 2025

is it suggested to use sentry for monitoring in production with express v5 (performance , profiling and error tracing ) ?
we are migrating a few projects to v5 and i encountered the instrumentation warning , landed here i guess its going to take some time before sentry supports v5 . can we have a timeline for that ?

@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 3 Jan 21, 2025
@andreiborza
Copy link
Member

@kvjoshi we are still waiting on open-telemetry/opentelemetry-js-contrib#2437, at the moment we don't have an ETA. You can subscribe to this issue to get notified when we have updates.

@mydea
Copy link
Member Author

mydea commented Jan 21, 2025

Also, just one note here: You should be able to use Sentry with Express 5, you'll just lack a few performance-related data points: You will not have properly parametrized routes, as well as e.g. middleware spans will be lacking. Error monitoring and basic http-server tracing will still work, even now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Package: node Issues related to the Sentry Node SDK Package-Meta: OpenTelemetry
Projects
Status: No status
Development

No branches or pull requests

7 participants