-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge with gdoc2adoc project #25
Comments
I haven't had a chance to look at the other project. I'll get to it this weekend 💯 |
FYI - I actually did my best to start from this project but when I started I did not know enough about google doc api to fix the bugs I saw - now that I completed my work (based of a markdown variation) I got what I so far can see does the conversion better (full support for tables, nested formatting and most important support for images). The only feature I did not replicate was the "select part of text and convert", but we can look at how to bring that back while still have the image feature supported. If you find something missing let me know. I was actually thinking if we shuold move this work to asciidoctor org ? /cc @mojavelinux |
This is definitely a tool I'd like to see in the Asciidoctor organization. I'm not sure about the name (gdoc2adoc), though. While I see that "gdoc2*" or "gdocs2*" is a popular naming scheme, I wonder if it will be easy enough to find. One solution is to fold the new code into the current repository so we can reuse the name asciidoc-googledocs-addoc. I'm open to suggestions. Just keep in mind the goal is just to make it easy to discover. |
@maxandersen I did a quick test today and your extension is working great. However I found a few issues with the formatting. I'm using the following document to test the conversion: https://docs.google.com/document/d/1gaxFyGqutLKSmWoznxtonRCWNRYwd_Gl0aNVBKU9p4U On left gdoc2adoc and on right the AsciiDoc Processor Addon:
How do you want to proceed with this issue ? |
Thanks for looking!
this is caused by the formatting code not looking "forward" - should probably look at taking what is done in this project to get it better. Related to maxandersen/gdoc2adoc#6
Did not look - but yes, annoying ;/ maxandersen/gdoc2adoc#15
underline was not even covered at all - i fixed that now ;)
yeah, I found this too. my logic used to trigger top level macro has a bug. need to find another way to handle it. maxandersen/gdoc2adoc#16
This is due to font detection only looking at courier new - have extended it but still not handling multiline the best. maxandersen/gdoc2adoc#17
I'll try fix some over the weekend.
I tried submitting it but it always fails with an error - no explanation why :/ it works fine when I install it "locally" so not sure why it fails on simply submitting it for review. |
The following project has the same goal and supports a wide range of features.
I think it makes sense to merge the two projects.
https://github.com/maxandersen/gdoc2adoc
/cc @maxandersen
The text was updated successfully, but these errors were encountered: