Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stable Release #9

Open
3 of 4 tasks
davidt99 opened this issue Dec 12, 2017 · 5 comments
Open
3 of 4 tasks

Stable Release #9

davidt99 opened this issue Dec 12, 2017 · 5 comments

Comments

@davidt99
Copy link
Contributor

davidt99 commented Dec 12, 2017

This issue is tracking the stuff that need to be done in order to have a stable release.
@glaslos feel free to reject/add stuff/discuss this with me. We are close to have this implementation usable for production.

What we need to do:

  • Create stateless api for fuzzy file and fuzzy bytes. I feel like the SSDEEP struct doesn't have much purpose.
  • Better documrntation.
  • More testing for integrity.
  • Verify that the distance function is correct - looking at the code, it seems that the implementation is incomplete.
@glaslos
Copy link
Owner

glaslos commented Dec 13, 2017

I do like the idea of using the Hash interface. It kind of conflicts with your stateless proposal.
Can you add some sub points to the documentation? What kind of information do you think would make sense to be added there?
Integrity testing as in making sure our output matches the one from the reference implementation?
Otherwise I agree with your proposal. Feel free to add individual issues so we can split up the conversation a bit.

@glaslos
Copy link
Owner

glaslos commented Dec 14, 2017

I've split up all the issues and grouped them with a milestone: https://github.com/glaslos/ssdeep/milestone/1

@davidt99
Copy link
Contributor Author

I'll continue the discussion in the other issues.

@ayoubfaouzi
Copy link

Great work here, waiting for the stable release 👍

@requaos
Copy link

requaos commented Jul 9, 2018

I do like the io.Writer on the Hash interface... was missing that for computing many hashes in parallel with io.MultiWriter + io.Copy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants