Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MathematicaToPython.py needs refactoring #117

Open
bdice opened this issue Oct 12, 2020 · 1 comment
Open

MathematicaToPython.py needs refactoring #117

bdice opened this issue Oct 12, 2020 · 1 comment

Comments

@bdice
Copy link
Member

bdice commented Oct 12, 2020

The MathematicaToPython.py utility script is out of date and needs to be refactored. It refers to changed/removed APIs in coxeter.

Moreover, its intended usage isn't very clear to me, despite the long comment at the top. Is it possible to include a corresponding Mathematica script in this repository so the data is reproducible?

Should this file be kept someplace outside the coxeter package directory, in a scripts folder or something like that?

@vyasr
Copy link
Contributor

vyasr commented Oct 12, 2020

It would be nice to write a Mathematica script for this. I think I spent a couple minutes once to figure out how to get the data, but I didn't spend the time to write one. I'm not sure whether this belongs in here at all; at this point maybe we just accept that these are the shapes from that paper, and not worry about how to regenerate them. If we want to keep it in, then I'm fine moving it to a scripts directory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants