-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove properties that aren't implemented from docs #184
Comments
The cleanest way to solve this would be to selectively disable |
One alternative would be to simply remove the base class implementations. Having these "abstract" (in quotes because they aren't really abstract in the sense of Python's
The benefits with respect to item 1 are a bit questionable. Since coxeter doesn't use true ABC For item 2, we could recoup most of the same benefits by using a simple decorator that modifies the method's doc attribute, like so:
|
Noted, I will give that a try |
Feature description
It should be clear in the documentation which properties are not implemented for a given shape. For example, 'minimal_centered_bounding_sphere' is not implemented for
shapes.ConvexSpheropolyhedron
but this is not clear in the documentation.Proposed solution
Either remove those properties from the class documentation or somehow make it clear that they are not implemented.
The text was updated successfully, but these errors were encountered: