Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double BYE when call is disconnected by Hangup button #43

Open
sobomax opened this issue Jul 17, 2024 · 1 comment
Open

Double BYE when call is disconnected by Hangup button #43

sobomax opened this issue Jul 17, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@sobomax
Copy link

sobomax commented Jul 17, 2024

I've noticed the SaraP is generating double BYE when established session is disconnected using "Hangup" button on the web. The SIP.js demo client does not have this issue, so it suggests some incorrect API usage somewhere.

sara.log
sipjs.log
ScreenShot1323

@gmaruzz gmaruzz added the enhancement New feature or request label Jul 18, 2024
@gmaruzz
Copy link
Owner

gmaruzz commented Jul 18, 2024

ciao Max!

Actually, IIRC, is by design: everything and anything that happens that endangers, ends, or makes problem to the call leg close the session and generates a BYE (so to maintain consistency in the sip.js library state machine).

I will release a new version of SaraPhone when my lazyness will allow me, based on the latest "normal" version of sip.js (15.x, before the typescript/postmodern mayhem). But it probably will still have that behavior.

Anyway, if you deeply test a patch modifying this behavior, it may be merged.

What I want to avoid at all costs is to have SaraPhone blocked invisibly because sip.js is in inconsistent state because some unexpected signaling/network/whatever problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants