Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] CGO and No CGO being compared in coverage tests #91

Open
gdey opened this issue Nov 5, 2019 · 0 comments
Open

[ci] CGO and No CGO being compared in coverage tests #91

gdey opened this issue Nov 5, 2019 · 0 comments

Comments

@gdey
Copy link
Member

gdey commented Nov 5, 2019

We should either turn off one of them (No CGO has my vote), or figure out how to separate them in coverall api

To disable push of the cover information we just need to remove the --coveralls. To have different coverprofile, we just need to pass in --coverprofile=$name

The easiest thing might be to use the `--coverprofile=default${CGO_ENABLED}" flag to the coverall and that should have different cover profiles?

But this is a bit of a hack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant