Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary scrollbars in Admin pages [Firefox] #11936

Open
RoboMagus opened this issue Nov 6, 2024 · 2 comments · May be fixed by #12600
Open

Unnecessary scrollbars in Admin pages [Firefox] #11936

RoboMagus opened this issue Nov 6, 2024 · 2 comments · May be fixed by #12600
Labels
bug Something isn't working

Comments

@RoboMagus
Copy link
Contributor

Describe the bug
I've noticed a minor UI bug in Firefox; the admin pages often contain unnecessary scrollbars. This is only reproducible in Firefox it seems. (Further digging & potential solution in Additional Context)

To Reproduce
Steps to reproduce the behavior:

  1. Open the Admin dashboard overview page in Firefox browser.
  2. Compare against same page in any chromium based browser.

Expected behavior
No scrollbars when not necessary.

Screenshots
Firefox:
authentik_admin_firefox

Chrome:
authentik_admin_chromium

Logs
N/a

Version and Deployment (please complete the following information):

  • authentik version: 2024.8.4
  • Deployment: docker-compose

Additional context
After looking at the CSS for the Admin page, it seems to occur on elements of the .pf-c-card__body class which sets overflow-x: scroll;.
As Firefox has poor support for ::-webkit-scrollbar it will not use the custom scrollbar styling defined in authentik.css.

Not sure if this would be the proper way of fixing this, but setting the overflow to auto seems to resolve the issue. Perhaps conditionally by checking if the browser supports webkit-scrollbar.

Alternatively standardized scrollbar styling could be used as noted by the webkit-scrollbar dev pages.

@RoboMagus RoboMagus added the bug Something isn't working label Nov 6, 2024
@authentik-automation
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@RoboMagus
Copy link
Contributor Author

As I prefer using Firefox lately I'll see if I can make the required changes and open up a PR to fix this issue, So lets keep this open for now ;)

@rissson rissson removed the wontfix label Jan 8, 2025
@RoboMagus RoboMagus linked a pull request Jan 8, 2025 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants