Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NewVersion has problems dealing with Recipe files including multibyte character #13

Closed
AitorATuin opened this issue Jan 20, 2017 · 5 comments
Closed

NewVersion has problems dealing with Recipe files including multibyte character #13

AitorATuin opened this issue Jan 20, 2017 · 5 comments
Assignees
@AitorATuin

Comments

@AitorATuin
Copy link
Contributor

AitorATuin commented Jan 20, 2017 •
edited
Loading

I have found that some recipes contain multibyte characters and NewVersion is complaining and failing to generate a new version of the Recipe.

❯ NewVersion Wireshark 2.2.3 https://1.na.dl.wireshark.org/src/wireshark-2.2.3.tar.bz2
NewVersion: Locating a recipe for Wireshark...
NewVersion: Found recipe for Wireshark at /Data/Compile/LocalRecipes/Wireshark/2.2.0
GetRecipe: Trying to get /Data/Compile/LocalRecipes/Wireshark/2.2.0
NewVersion: Recipe placed in /Data/Compile/LocalRecipes/Wireshark/2.2.0
NewVersion: Creating recipe for Wireshark 2.2.3 based on 2.2.0.
Recipe: línea 2: Coincidencia: no se encontró la orden
Recipe: línea 2: Coincidencia: no se encontró la orden
NewVersion: Downloading source code...
/Data/Compile/LocalRecipes/Wireshark/2.2.3/Recipe: línea 2: Coincidencia: no se encontró la orden
@AitorATuin AitorATuin self-assigned this Jan 20, 2017
@AitorATuin AitorATuin changed the title NewVersion has problems dealing with Recipe files including NUL character NewVersion has problems dealing with Recipe files including multibyte character Jan 20, 2017
@lucasvr
Copy link
Member

lucasvr commented Jan 20, 2017

NewVersion is quite hackish and has a set of known issues (see #11, for instance.) I'd say that the best approach would be to rewrite it on e.g., Python.

@AitorATuin
Copy link
Contributor Author

Agreed. Anyway the fix is straightforward so i will send a PR to fix it.

@AitorATuin AitorATuin mentioned this issue Jan 20, 2017
Merged
@AitorATuin
Copy link
Contributor Author

PR fixing it: #14

@AitorATuin
Copy link
Contributor Author

AitorATuin commented Jan 20, 2017 •
edited
Loading

btw maybe is time to give it a chance to lua :)

@lucasvr
Copy link
Member

lucasvr commented Jan 20, 2017

I wouldn't mind at all to have it rewritten in Lua. PRs are welcome :)

@lucasvr lucasvr closed this as completed Jan 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AitorATuin AitorATuin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AitorATuin @lucasvr