-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Harbor-UI should display the actual OCI 1.1 artifactType
for artifact accessories
#21345
Comments
The artifactType is an attribute defined in the OCI specification, specifically for the referers API. Are you asking if you'd like to see the artifactType of the pushed accessory displayed in the Harbor UI? And can you show us the use case? By the way, the type of accessory is defined within Harbor itself. By default, it is set to subject.accessory. However, when Harbor recognizes the pushed accessory — such as a signature generated by Notary or Cosign — it will be displayed as subject.signature, subject.sbom, and so on. |
Yes, that is exactly what I am asking for :) For the use-case: As shown in the screenshot above, there is currently no way to see in the UI what the type of a accessory is. For example, if a project maintainer wants to delete the attached trivy vulnerability results (e.g. to let an external process re-generate the trivy results), how can the maintainer possibly know which artifact to delete? Is it
Yes, but this is limited to the few types that Harbor natively recognizes. As a true OCI 1.1 compatible registry, the artifactType should be first-class attribute, not only some implementation detail that Harbor maps to a limited set of predefined types. |
Is your feature request related to a problem? Please describe.
We are using true OCI artifacts to attach SBOMs and vulnerability scan results to our images by using the Referrers-API as specified by the OCI Distribution spec 1.1. In the OCI Image spec 1.1, the
artifactType
is a new top-level attribute of the artifact manifest.Unfortunately, Harbor doesn't show the artifact-type of an artifact when using the UI. Example screenshot:
As you can see, the type of the attachments is always showing as
subject.accessory
, which isn't very helpful. The true types of the shown artifacts aretrivy-sbom/cyclonedx
andtrivy-vuln/results
. The actual types are shown neither in the listing of the accessories, nor when showing the artifact details of an accessory!Describe the solution you'd like
I think the fallback type
subject.accessory
used by Harbor is mostly useless. It should instead show the actualartifactType
of the artifact, if available. Alternatively we could introduce a new column namedArtifact type
, but this could be problematic since there is not a lot of horizontal space available.The artifact type should also be displayed when viewing the details of the artifact by clicking on a specific accessory.
This proposal probably depends on an addition to the accessories-API as described here:
artifactType
of the artifact #21344The text was updated successfully, but these errors were encountered: